fix(devkit): enhance pkg require errors and rescue a failing generator #30185
+24
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please note that this change affects both
nextanddevkitpackages. I've decided to attribute it to the one with the broader impact (devkit).Current Behavior
On a new nx monorepo, when you install
@nx/nextand run:the command fails, even though without the
dryRunflag it passes. Due to the error, thedryRunoutput is obscured and there's no obvious reason for it.Expected Behavior
The proper
dryRunoutput is printed and a warning message informs that playwright will be installed once not in adryRunmodeRelated Issue(s)
Fixes #30184