Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bundling): support rollup.config.ts #29983

Merged
merged 1 commit into from
Feb 25, 2025

Conversation

ThePlenkov
Copy link
Contributor

Current Behavior

Error when using rollup.config.ts

NX   Failed to process project graph.

2 errors occurred while processing files for the @nx/rollup/plugin plugin.
  - packages/codygen/rollup.config.cts: Unknown file extension ".cts" for /workspaces/codygen/packages/codygen/rollup.config.cts
  - sample3/rollup.config.ts: Unknown file extension ".ts" for /workspaces/codygen/sample3/rollup.config.ts 

Expected Behavior

Plugin should be able to load rollup.config.ts

Related Issue(s)

Fixes #29982

@ThePlenkov ThePlenkov requested a review from a team as a code owner February 11, 2025 14:23
@ThePlenkov ThePlenkov requested a review from Coly010 February 11, 2025 14:23
Copy link

vercel bot commented Feb 11, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Feb 11, 2025 2:26pm

Copy link

nx-cloud bot commented Feb 11, 2025

View your CI Pipeline Execution ↗ for commit d590e65.

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ✅ Succeeded 28m 29s View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 23s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 2s View ↗
nx-cloud record -- nx format:check --base= --he... ✅ Succeeded 11s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded 10s View ↗
nx documentation ✅ Succeeded 2m 16s View ↗

☁️ Nx Cloud last updated this comment at 2025-02-11 14:59:19 UTC

@ThePlenkov
Copy link
Contributor Author

Here is the repo where it works ( via patch ): https://github.com/ThePlenkov/nx-rollup-ts-config

@Coly010 Coly010 merged commit 63cb68d into nrwl:master Feb 25, 2025
12 checks passed
@Coly010
Copy link
Contributor

Coly010 commented Feb 25, 2025

Thank you for being proactive and fixing this! 🎉

Copy link

github-actions bot commented Mar 3, 2025

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unknown file extension ".ts" for /.../rollup.config.ts
2 participants