fix(core): improve resolution of packages in package manager workspaces when constructing the project graph #29795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
|
View your CI Pipeline Execution ↗ for commit 873fc7c.
☁️ Nx Cloud last updated this comment at |
leosvelperez
force-pushed
the
core/fix-workspaces-projects-handling
branch
from
2da66b3 to
5cc03ea
Compare
4 tasks
leosvelperez
force-pushed
the
core/fix-workspaces-projects-handling
branch
from
5cc03ea to
b66407d
Compare
leosvelperez
requested review from
meeroslav,
vsavkin,
mandarini and
a team
as code owners
…es when constructing the project graph
leosvelperez
force-pushed
the
core/fix-workspaces-projects-handling
branch
from
b66407d to
873fc7c
Compare
jaysoo
approved these changes
Feb 3, 2025
FrozenPandaz
pushed a commit
that referenced
this pull request
Feb 6, 2025
…es when constructing the project graph (#29795) Main fixes: - Identify dependencies from packages that only expose named exports (no `.` export) - Identify dependencies from exports containing wildcards (e.g. `"./utils/*": "./src/utils/*.js`) - Disallow identifying dependencies from restricted exports (e.g. `"./foo": null`) - Handle conditional exports (e.g. `"exports": { "import": "./dist/index.js", "default": "./dist/index.js" }` - Handle invalid `"exports": {}` (by not falling back to `main`) - Handle projects included or not in package manager workspaces ## Current Behavior ## Expected Behavior ## Related Issue(s) Fixes #29486 (cherry picked from commit 4235cf3)
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main fixes:
.export)"./utils/*": "./src/utils/*.js)"./foo": null)"exports": { "import": "./dist/index.js", "default": "./dist/index.js" }"exports": {}(by not falling back tomain)Current Behavior
Expected Behavior
Related Issue(s)
Fixes #29486