Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(webpack, rspack): support multiple configurations #29691

Merged
merged 2 commits into from
Jan 23, 2025

Conversation

ndcunningham
Copy link
Contributor

@ndcunningham ndcunningham commented Jan 20, 2025

This pull request includes changes to support multi-configuration mode for both Rspack and Webpack.

Currently

Currently our plugin only supports single configurations

module.exports =  { 
  ...config
}

Which works in most cases but some applications can have mutliple configs that serve different platforms.

Changes

With these changes, the Webpack and Rspack plugins will also support multi-configuration.

module.exports = [ 
   { ...clientConfig },
   { ...serverConfig }
 ] 

@ndcunningham ndcunningham added the scope: bundlers Issues related to webpack, rollup label Jan 20, 2025
@ndcunningham ndcunningham self-assigned this Jan 20, 2025
Copy link

vercel bot commented Jan 20, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Jan 23, 2025 1:11am

Copy link

nx-cloud bot commented Jan 20, 2025

View your CI Pipeline Execution ↗ for commit f9e24de.

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ✅ Succeeded 29m 27s View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 1m 5s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 1s View ↗
nx-cloud record -- nx format:check --base=12360... ✅ Succeeded 26s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded 24s View ↗
nx documentation --no-dte ✅ Succeeded 47s View ↗

☁️ Nx Cloud last updated this comment at 2025-01-23 01:45:20 UTC

@ndcunningham ndcunningham changed the title feat(webpack): support multiple webpack configurations feat(webpack, rspack): support multiple configurations Jan 21, 2025
@ndcunningham ndcunningham marked this pull request as ready for review January 21, 2025 14:06
@ndcunningham ndcunningham requested a review from a team as a code owner January 21, 2025 14:06
@ndcunningham ndcunningham force-pushed the feat/support-multiple-configs-webpack-rspack branch from d1b6f5d to 1c5738a Compare January 21, 2025 21:54
@ndcunningham ndcunningham force-pushed the feat/support-multiple-configs-webpack-rspack branch 2 times, most recently from 27f396c to ef21793 Compare January 22, 2025 18:17
@jaysoo
Copy link
Member

jaysoo commented Jan 22, 2025

LGTM, we should add a couple of e2e test cases to cover multi-builds.

@ndcunningham ndcunningham force-pushed the feat/support-multiple-configs-webpack-rspack branch from 27989ef to 44d748e Compare January 23, 2025 00:57
feat(rspack): support multi-configuration mode in Rspack options
@ndcunningham ndcunningham force-pushed the feat/support-multiple-configs-webpack-rspack branch from 44d748e to f9e24de Compare January 23, 2025 01:09
@ndcunningham ndcunningham merged commit 7524356 into master Jan 23, 2025
12 of 13 checks passed
@ndcunningham ndcunningham deleted the feat/support-multiple-configs-webpack-rspack branch January 23, 2025 01:50
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
scope: bundlers Issues related to webpack, rollup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants