fix(rspack): make subresourceIntegrity usage configurable #29629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
|
View your CI Pipeline Execution ↗ for commit fb561ff.
☁️ Nx Cloud last updated this comment at |
jaysoo
approved these changes
Jan 15, 2025
FrozenPandaz
pushed a commit
that referenced
this pull request
Jan 15, 2025
## Current Behavior We currently set Subresource Integrity (SRI) on all scripts injected via `HtmlRspackPlugin`. This should be configurable. ## Expected Behavior Expose an option to set SRI - mark false by default to match Rspack's `HtmlRspackPlugin` behaviour (cherry picked from commit 0d5e53d)
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
We currently set Subresource Integrity (SRI) on all scripts injected via
HtmlRspackPlugin.This should be configurable.
Expected Behavior
Expose an option to set SRI - mark false by default to match Rspack's
HtmlRspackPluginbehaviour