fix(core): update package script logic to handle cli tool name as command #29617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
|
View your CI Pipeline Execution ↗ for commit e5fa7af.
☁️ Nx Cloud last updated this comment at |
leosvelperez
approved these changes
Jan 14, 2025
JamesHenry
reviewed
Jan 14, 2025
JamesHenry
reviewed
Jan 14, 2025
Coly010
force-pushed
the
update-package-scripts-scoring-logic
branch
from
4a52244 to
a6ddaa1
Compare
Coly010
force-pushed
the
update-package-scripts-scoring-logic
branch
from
a6ddaa1 to
e5fa7af
Compare
JamesHenry
approved these changes
Jan 14, 2025
FrozenPandaz
pushed a commit
that referenced
this pull request
Jan 15, 2025
…mand (#29617) ## Current Behavior When we have an inferred target command that matches the entry point of the cli tool, there is a chance we do not replace package scripts correctly e.g. ``` { "dev": "vite", "build": "tsc -b && vite build", "preview": "vite preview" } ``` this could result in package scripts being updated to ``` { "dev": "nx dev", "build": "tsc -b && nx vite:build", "preview": "nx dev preview" } ``` ## Expected Behavior We should update the package scripts correctly to match the desired inferred target ``` { "preview": "nx preview" } ``` (cherry picked from commit c2fa9a0)
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
When we have an inferred target command that matches the entry point of the cli tool, there is a chance we do not replace package scripts correctly
e.g.
this could result in package scripts being updated to
Expected Behavior
We should update the package scripts correctly to match the desired inferred target