fix(angular): restore esm2022 bundle and drop fesm2022 in ng-packagr-lite executor #29615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
|
View your CI Pipeline Execution ↗ for commit ee72bfe.
☁️ Nx Cloud last updated this comment at |
leosvelperez
force-pushed
the
angular/ng-packagr-esm2022
branch
from
a0f6438 to
dc95a51
Compare
Coly010
approved these changes
Jan 14, 2025
leosvelperez
force-pushed
the
angular/ng-packagr-esm2022
branch
from
dc95a51 to
ee72bfe
Compare
FrozenPandaz
pushed a commit
that referenced
this pull request
Jan 15, 2025
…lite executor (#29615) ## Current Behavior In Nx 20.2.0, the `ng-packagr-lite` executor stopped producing the ESM2022 outputs and started producing the FESM2022 outputs. This was due to the Angular Package Format (APF) dropping the ESM2022 outputs, which was reflected in the upstream `ng-packagr` implementation. Due to this change, the libraries' build time and memory increased compared to the previous versions. ## Expected Behavior The `ng-packagr-lite` executor should only produce ESM2022 outputs and avoid running an extra step to bundle the outputs to produce the FESM2022. Given the `ng-packagr-lite` executor is not meant to produce publishable artifacts, its output doesn't need to strictly comply with the APF and can focus more on build performance. ## Related Issue(s) Fixes #29519 (cherry picked from commit f24a869)
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
In Nx 20.2.0, the
ng-packagr-liteexecutor stopped producing the ESM2022 outputs and started producing the FESM2022 outputs. This was due to the Angular Package Format (APF) dropping the ESM2022 outputs, which was reflected in the upstreamng-packagrimplementation. Due to this change, the libraries' build time and memory increased compared to the previous versions.Expected Behavior
The
ng-packagr-liteexecutor should only produce ESM2022 outputs and avoid running an extra step to bundle the outputs to produce the FESM2022.Given the
ng-packagr-liteexecutor is not meant to produce publishable artifacts, its output doesn't need to strictly comply with the APF and can focus more on build performance.Related Issue(s)
Fixes #29519