fix(vite): plugin should infer 'vite' for dev/serve command #29585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
|
View your CI Pipeline Execution ↗ for commit 80fd4f4.
☁️ Nx Cloud last updated this comment at |
Coly010
force-pushed
the
vite/fix-inferred-target
branch
from
13c5376 to
21a6d1d
Compare
jaysoo
reviewed
Jan 13, 2025
Coly010
force-pushed
the
vite/fix-inferred-target
branch
from
21a6d1d to
80fd4f4
Compare
jaysoo
approved these changes
Jan 15, 2025
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
We currently have a
serveTargetNamethat defaults toservein the@nx/vite/plugin.This infers a
vite servecommand for theservetask to vite projects.While not incorrect, it could be abrasive for users coming from the
viteecosystem to Nx.The command to start the Vite Dev Server is
vite, so we should infer this.create-vitealso creates a package.json script with"dev": "vite"meaning users are likely runningnpm run dev.This creates two points of differences for vite ecosystem users.
Expected Behavior
Deprecate
serveTargetNamein favour ofdevTargetNameto more closely align with lanugage from the Vite ecosystem.Infer the command
viteinstead ofvite servefor theserveanddevtasks.