feat(core): add support for skipping remote cache #29574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
View your CI Pipeline Execution ↗ for commit ac0f1a4.
☁️ Nx Cloud last updated this comment at |
FrozenPandaz
requested changes
Jan 9, 2025
| @@ -90,6 +91,11 @@ export function withRunOptions<T>(yargs: Argv<T>): Argv<T & RunOptions> { | |||
| type: 'boolean', | |||
| default: false, | |||
| }) | |||
| .options('skipRemoteCache', { | |||
| type: 'boolean', | |||
| describe: 'Do not save cache results to the remote cache.', | |||
There was a problem hiding this comment.
Suggested change
| describe: 'Do not save cache results to the remote cache.', | |
| describe: 'Disables the remote cache.', |
| @@ -75,6 +75,7 @@ export interface DefaultTasksRunnerOptions { | |||
| lifeCycle: LifeCycle; | |||
| captureStderr?: boolean; | |||
| skipNxCache?: boolean; | |||
| skipRemoteCache?: boolean; | |||
Cammisuli
force-pushed
the
feature/nxc-1318-add-option-to-skip-all-remote-caches-in-nx
branch
from
d6a05be to
c21f3e2
Compare
- Introduced `skipRemoteCache` option to bypass saving and reading from remote cache. - Updated command-line and configuration options to support `skipRemoteCache`. - Adjusted cache runner logic to handle `skipRemoteCache` flag and log warnings when remote cache is disabled.
Cammisuli
force-pushed
the
feature/nxc-1318-add-option-to-skip-all-remote-caches-in-nx
branch
from
2bcb3f5 to
025816c
Compare
AgentEnder
reviewed
Jan 14, 2025
Comment on lines
77
to
78
| skipNxCache?: boolean; | ||
| disableRemoteCache?: boolean; |
There was a problem hiding this comment.
What's the reason for disable vs skip here? I feel like it should match with the --skip-nx-cache flag
There was a problem hiding this comment.
Yup, I was discussing this with Jason.
Comment on lines
+195
to
+200
| output.warn({ | ||
| title: 'Remote Cache Disabled', | ||
| bodyLines: [ | ||
| 'Nx will continue running, but nothing will be written or read from the remote cache.', | ||
| ], | ||
| }); |
There was a problem hiding this comment.
Handle this in the old cache as well.
FrozenPandaz
approved these changes
Jan 15, 2025
| @@ -103,6 +103,7 @@ Print the task graph to the console: | |||
| | `--parallel` | string | Max number of parallel processes [default is 3]. | | |||
| | `--runner` | string | This is the name of the tasks runner configured in nx.json. | | |||
| | `--skipNxCache` | boolean | Rerun the tasks even when the results are available in the cache. (Default: `false`) | | |||
| | `--skipRemoteCache` | boolean | Disables the remote cache. (Default: `false`) | | |||
There was a problem hiding this comment.
This doesn't show the different aliases? @isaacplmann can we update nx.dev to show all of the aliases here? 🤔
FrozenPandaz
deleted the
feature/nxc-1318-add-option-to-skip-all-remote-caches-in-nx
branch
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Expected Behavior
Related Issue(s)
Fixes #