Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(linter): export Options types for enforce-module-boundaries and nx-plugin-checks #29072

Conversation

oliveryasuna
Copy link
Contributor

@oliveryasuna oliveryasuna commented Nov 26, 2024

Closes #28866

Current Behavior

Options in enforce-module-boundaries.ts and nx-plugin-checks are not exported.

Expected Behavior

They are now exported.

Related Issue(s)

Fixes #28866

…daries-options-type' into 28866-export-enforce-module-boundaries-options-type
@oliveryasuna oliveryasuna requested a review from a team as a code owner November 26, 2024 04:07
Copy link

vercel bot commented Nov 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Jan 12, 2025 9:54pm

Copy link

nx-cloud bot commented Nov 26, 2024

View your CI Pipeline Execution ↗ for commit 431b07e.

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ✅ Succeeded 35m 25s View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 1m 10s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 2s View ↗
nx-cloud record -- nx format:check --base=dc2c9... ✅ Succeeded 25s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded 23s View ↗
nx documentation --no-dte ✅ Succeeded 50s View ↗

☁️ Nx Cloud last updated this comment at 2025-01-12 22:30:36 UTC

Copy link
Collaborator

@JamesHenry JamesHenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry for the delay @oliveryasuna, thanks for this

@JamesHenry JamesHenry merged commit f3b85be into nrwl:master Jan 24, 2025
6 checks passed
@JamesHenry JamesHenry changed the title fix(linter): exported Options for the ESLint `enforce-module-bounda… fix(linter): export Options types for enforce-module-boundaries and nx-plugin-checks Jan 24, 2025
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

eslint-plugin Options for rule enforce-module-boundaries is not exported, like dependency-checks
2 participants