Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): handle existing plugins failed with imported project #28893

Merged
merged 1 commit into from
Jan 17, 2025
Merged

feat(core): handle existing plugins failed with imported project #28893

merged 1 commit into from
Jan 17, 2025

Conversation

xiongemi
Copy link
Collaborator

@xiongemi xiongemi commented Nov 12, 2024 •
edited
Loading

Current Behavior

Expected Behavior

Screenshot 2024-12-21 at 9 51 18 PM

Related Issue(s)

Fixes #

@xiongemi xiongemi requested review from a team as code owners November 12, 2024 06:37
@vercel Vercel
Copy link

vercel bot commented Nov 12, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Jan 15, 2025 9:29pm

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Nov 12, 2024 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 4f9f0c6.

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ✅ Succeeded 39m 56s View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 1m 6s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 2s View ↗
nx-cloud record -- nx format:check --base=cc441... ✅ Succeeded 31s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded 29s View ↗
nx documentation --no-dte ✅ Succeeded 1m 10s View ↗

☁️ Nx Cloud last updated this comment at 2025-01-15 22:09:00 UTC

@xiongemi xiongemi changed the title feat(core): Handle when an existing plugin begins to fail with the ne… feat(core): handle existing plugins failed with imported project Nov 12, 2024
@xiongemi xiongemi force-pushed the feature/nxc-1185-handle-when-an-existing-plugin-begins-to-fail-with-the-new branch from d58df35 to 8c0a118 Compare November 12, 2024 18:11
@xiongemi xiongemi force-pushed the feature/nxc-1185-handle-when-an-existing-plugin-begins-to-fail-with-the-new branch from 8c0a118 to 5caa651 Compare November 12, 2024 21:33
@xiongemi xiongemi requested a review from a team as a code owner November 12, 2024 21:33
@xiongemi xiongemi force-pushed the feature/nxc-1185-handle-when-an-existing-plugin-begins-to-fail-with-the-new branch from 5caa651 to d8628ce Compare November 13, 2024 16:38
@xiongemi xiongemi requested a review from a team as a code owner November 13, 2024 16:38
@xiongemi xiongemi force-pushed the feature/nxc-1185-handle-when-an-existing-plugin-begins-to-fail-with-the-new branch from d8628ce to 0a30ebc Compare November 13, 2024 16:39
@xiongemi xiongemi force-pushed the feature/nxc-1185-handle-when-an-existing-plugin-begins-to-fail-with-the-new branch from 0a30ebc to 5a9ea09 Compare November 15, 2024 06:41
@xiongemi xiongemi requested a review from jaysoo November 15, 2024 06:41
@xiongemi xiongemi force-pushed the feature/nxc-1185-handle-when-an-existing-plugin-begins-to-fail-with-the-new branch from 5a9ea09 to 5374b48 Compare November 18, 2024 05:22
@xiongemi xiongemi force-pushed the feature/nxc-1185-handle-when-an-existing-plugin-begins-to-fail-with-the-new branch from 5374b48 to 1e4b0b4 Compare November 19, 2024 20:09
@xiongemi xiongemi force-pushed the feature/nxc-1185-handle-when-an-existing-plugin-begins-to-fail-with-the-new branch from 1e4b0b4 to 9c336a2 Compare November 25, 2024 18:23
@xiongemi xiongemi force-pushed the feature/nxc-1185-handle-when-an-existing-plugin-begins-to-fail-with-the-new branch 2 times, most recently from 45aa101 to 9954bbb Compare December 20, 2024 07:30
@xiongemi xiongemi force-pushed the feature/nxc-1185-handle-when-an-existing-plugin-begins-to-fail-with-the-new branch from 9954bbb to 8794a5a Compare December 20, 2024 16:44
@xiongemi xiongemi force-pushed the feature/nxc-1185-handle-when-an-existing-plugin-begins-to-fail-with-the-new branch from 8794a5a to e6561ed Compare December 20, 2024 19:24
@xiongemi xiongemi force-pushed the feature/nxc-1185-handle-when-an-existing-plugin-begins-to-fail-with-the-new branch from e6561ed to aa9c5bc Compare December 20, 2024 22:59
@xiongemi xiongemi force-pushed the feature/nxc-1185-handle-when-an-existing-plugin-begins-to-fail-with-the-new branch from aa9c5bc to 5147756 Compare January 10, 2025 07:30
@xiongemi xiongemi requested a review from a team as a code owner January 10, 2025 07:30
@xiongemi xiongemi force-pushed the feature/nxc-1185-handle-when-an-existing-plugin-begins-to-fail-with-the-new branch from 5147756 to de5f133 Compare January 10, 2025 15:39
@xiongemi xiongemi force-pushed the feature/nxc-1185-handle-when-an-existing-plugin-begins-to-fail-with-the-new branch from de5f133 to f0819c8 Compare January 10, 2025 16:35
@xiongemi xiongemi requested a review from FrozenPandaz January 13, 2025 19:21
FrozenPandaz
FrozenPandaz approved these changes Jan 15, 2025
View reviewed changes
@xiongemi xiongemi force-pushed the feature/nxc-1185-handle-when-an-existing-plugin-begins-to-fail-with-the-new branch from f0819c8 to e31f36e Compare January 15, 2025 19:07
@xiongemi xiongemi force-pushed the feature/nxc-1185-handle-when-an-existing-plugin-begins-to-fail-with-the-new branch from e31f36e to 755c4a5 Compare January 15, 2025 20:22
@xiongemi xiongemi force-pushed the feature/nxc-1185-handle-when-an-existing-plugin-begins-to-fail-with-the-new branch from 755c4a5 to 4f9f0c6 Compare January 15, 2025 21:21
@xiongemi xiongemi merged commit ee135b2 into master Jan 17, 2025
6 checks passed
@xiongemi xiongemi deleted the feature/nxc-1185-handle-when-an-existing-plugin-begins-to-fail-with-the-new branch January 17, 2025 20:06
@github-actions GitHub Actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@FrozenPandaz FrozenPandaz FrozenPandaz approved these changes

@AgentEnder AgentEnder Awaiting requested review from AgentEnder AgentEnder is a code owner automatically assigned from nrwl/nx-core-reviewers

@jaysoo jaysoo Awaiting requested review from jaysoo

Assignees

@xiongemi xiongemi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xiongemi @jaysoo @FrozenPandaz