-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new nx create missing @eslint/eslintrc dependency #29845
Comments
I also cleared out everything and tried to use pnpx to create a new project, can't even get it created ➜ dev pnpx create-nx-workspace NX Let's create a new workspace [https://nx.dev/getting-started/intro] ✔ Where would you like to create your workspace? · myorg NX Creating your v20.4.0 workspace. ✔ Installing dependencies with pnpm NX Failed to generate CI workflow Exit code: 1 ➜ dev more /Volumes/dev/myorg/error.log NX Failed to process project graph. An error occurred while processing files for the @nx/eslint/plugin plugin.
/Volumes/dev/myorg/error.log (END) |
Looks like the issue happens specifically with pnpm@10 and ESLint. We'll look into it. In the meantime you could pass
|
tried that, also did not work test git:(master) ✗ pnpx create-nx-workspace --workspaces NX Let's create a new workspace [https://nx.dev/getting-started/intro] ✔ Where would you like to create your workspace? · mytest NX Creating your v20.4.2 workspace. ✔ Installing dependencies with pnpm NX Failed to generate CI workflow Exit code: 1 ➜ test git:(master) ✗ more /Volumes/dev/test/mytest/error.log NX Failed to process project graph. An error occurred while processing files for the @nx/eslint/plugin plugin.
however skipping eslint on a subsequent attempt did work |
When flat compat is necessary, we don't ensure that `@eslint/eslintrc` is installed, even though we import it. Depending on the package manager and hoisting, it may still work, but as we see with pnpm v10, it is not working without an explicit dependency in `package.json`. <!-- If this is a particularly complex change or feature addition, you can request a dedicated Nx release for this pull request branch. Mention someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they will confirm if the PR warrants its own release for testing purposes, and generate it for you if appropriate. --> ## Current Behavior Some app generators are broken is we use eslint compat. ## Expected Behavior App generators should work. ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes #29845
When flat compat is necessary, we don't ensure that `@eslint/eslintrc` is installed, even though we import it. Depending on the package manager and hoisting, it may still work, but as we see with pnpm v10, it is not working without an explicit dependency in `package.json`. <!-- If this is a particularly complex change or feature addition, you can request a dedicated Nx release for this pull request branch. Mention someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they will confirm if the PR warrants its own release for testing purposes, and generate it for you if appropriate. --> ## Current Behavior Some app generators are broken is we use eslint compat. ## Expected Behavior App generators should work. ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes #29845
Current Behavior
Created a brand new nx project, then imported into pnpm, then attempted build. Got error @eslint/eslintrc was missing which is true, it was not in package.json
Expected Behavior
A brand new project should compile
GitHub Repo
No response
Steps to Reproduce
at this point I gave up. not sure why nx reset and then nx build throws various errors
Nx Report
Failure Logs
Package Manager Version
pnpm 10.1.0
Operating System
Additional Information
No response
The text was updated successfully, but these errors were encountered: