Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement new npm-packlist behavior #5602

Merged
merged 2 commits into from
Sep 30, 2022
Merged

feat: implement new npm-packlist behavior #5602

merged 2 commits into from
Sep 30, 2022

Conversation

lukekarrys
Copy link
Contributor

This also lands the latest pacote which now requires passing in an
Arborist constructor for use in loading the package tree that gets
passed to npm-packlist.

BREAKING CHANGE: npm pack now follows a strict order of operations
when applying ignore rules. If a files array is present in the
package.json, then rules in .gitignore and .npmignore files from the
root will be ignored.

@lukekarrys
Copy link
Contributor Author

lukekarrys commented Sep 28, 2022

This is a draft until npm/pacote#204 lands and is published. Currently this PR has the same behavior installed in node_modules from a tarball from that PR.

This is ready

This also lands the latest `pacote` which now requires passing in an
`Arborist` constructor for use in loading the package tree that gets
passed to `npm-packlist`.

BREAKING CHANGE: `npm pack` now follows a strict order of operations
when applying ignore rules. If a files array is present in the
package.json, then rules in .gitignore and .npmignore files from the
root will be ignored.
@npm-cli-bot
Copy link
Collaborator

npm-cli-bot commented Sep 28, 2022

found 20 benchmarks with statistically significant performance improvements

  • app-large: clean, lock-only, cache-only, cache-only:peer-deps, modules-only, no-lock, no-cache, no-modules, no-clean, no-clean:audit
  • app-medium: clean, lock-only, cache-only, cache-only:peer-deps, modules-only, no-lock, no-cache, no-modules, no-clean, no-clean:audit
timing results
app-large clean lock-only cache-only cache-only
peer-deps
modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 43.042 ±2.17 18.694 ±0.21 16.849 ±0.10 22.225 ±4.89 3.045 ±0.10 3.022 ±0.04 2.491 ±0.05 11.451 ±0.01 2.436 ±0.02 3.928 ±0.70
#5602 0.111 ±0.00 0.110 ±0.00 0.111 ±0.00 0.113 ±0.00 0.108 ±0.00 0.110 ±0.00 0.110 ±0.00 0.109 ±0.00 0.109 ±0.00 0.109 ±0.00
app-medium clean lock-only cache-only cache-only
peer-deps
modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 31.366 ±0.14 14.424 ±0.13 12.970 ±0.09 13.576 ±0.11 2.727 ±0.03 2.689 ±0.00 2.461 ±0.00 8.904 ±0.09 2.294 ±0.00 3.137 ±0.03
#5602 0.110 ±0.00 0.111 ±0.00 0.110 ±0.00 0.108 ±0.00 0.109 ±0.00 0.110 ±0.00 0.109 ±0.00 0.110 ±0.00 0.111 ±0.00 0.110 ±0.00

@lukekarrys lukekarrys marked this pull request as ready for review September 29, 2022 20:52
@lukekarrys lukekarrys requested a review from a team as a code owner September 29, 2022 20:52
@lukekarrys lukekarrys merged commit 45e43f1 into latest Sep 30, 2022
@lukekarrys lukekarrys deleted the lk/packlist-7 branch September 30, 2022 00:27
@github-actions github-actions bot mentioned this pull request Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants