Allow to search by "Name" on the product attribute page (admin area) #7518
+148
−90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated `IProductAttributeService` to include an optional `name` parameter in `GetAllProductAttributesAsync`. - Modified `ProductAttributeService` to filter product attributes by name using the new parameter. - Added a new locale resource for product attribute name search in the XML resource file. - Enhanced `ProductAttributeSearchModel` with a `SearchProductAttributeName` property. - Updated `List.cshtml` to include a search block for filtering product attributes by name. - Made minor formatting adjustments for improved code readability.
Updated LINQ query formatting in the ProductAttributeService class to enhance code readability. Adjusted indentation for `orderby`, `where`, and `select` clauses. Also, modified a comment in the `GetProductAttributeByIdsAsync` method for consistent formatting.
chrisjainsley
changed the title
Added a hint for "SearchProductAttributeName" in `LocalizationMigration.cs` and created a new locale resource entry in `defaultResources.nopres.xml`. Updated the HTML structure in `List.cshtml` for better layout and user interaction, including a restructured search block and improved button placements. JavaScript functionality for deleting selected attributes remains intact and has been reformatted for clarity.
qasas145
reviewed
Jan 29, 2025
src/Presentation/Nop.Web/App_Data/Localization/defaultResources.nopres.xml
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IProductAttributeServiceto include an optionalnameparameter inGetAllProductAttributesAsync.ProductAttributeServiceto filter product attributes by name using the new parameter.ProductAttributeSearchModelwith aSearchProductAttributeNameproperty.List.cshtmlto include a search block for filtering product attributes by name.#7515