Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double slash in path #67

Closed
dmugtasimov opened this issue Oct 6, 2018 · 3 comments
Closed

Double slash in path #67

dmugtasimov opened this issue Oct 6, 2018 · 3 comments

Comments

@dmugtasimov
Copy link
Contributor

When I run

from wampy.peers import Client

client = Client()
client.start()

I get

2018-10-06 15:25:21,280 DEBUG connection headers: ['GET //8080 HTTP/1.1', 'Host: localhost:8080', 'Upgrade: websocket', 'Connection: Upgrade', 'Sec-WebSocket-Key: pTTOyGC/QjClWaGYIlFaYw==', 'Origin: ws://localhost:8080', 'Sec-WebSocket-Version: 13', 'Sec-WebSocket-Protocol: wamp.2.json']

Should not it be GET / instead of GET //8080?

For

from wampy.peers.clients import Client
from wampy.peers.routers import Crossbar

with WampyApp(router=Crossbar(url='ws://127.0.0.1:8080/ws', config_path=config_path),
              roles=roles, message_handler=TicketMessageHandler('ticket')) as client:
    pass

I get

2018-10-06T15:26:13+0300 [Router      10075 crossbar.router.protocol.WampWebSocketServerProtocol] received HTTP request:

b'GET //ws HTTP/1.1\r\nHost: 127.0.0.1:8080\r\nUpgrade: websocket\r\nConnection: Upgrade\r\nSec-WebSocket-Key: 9Zby3RqBSLWA3Ovh2NLDJA==\r\nOrigin: ws://127.0.0.1:8080\r\nSec-WebSocket-Version: 13\r\nSec-WebSocket-Protocol: wamp.2.json\r\n\r\n'

on Crossbar side. Should it be GET /ws instead of GET //ws?

Please, let me know if you can't grasp the issue from the above description. I will prepare a full fledged example.

@dmugtasimov
Copy link
Contributor Author

@noisyboiler Hi! Have you reviewed this one?

@noisyboiler
Copy link
Owner

next on my radar!

@noisyboiler noisyboiler mentioned this issue Dec 31, 2018
@noisyboiler
Copy link
Owner

sorry this took so long to address. i do appreciate these things being raised.
👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants