doc: explicit mention arbitrary code execution as a vuln #57426
+4
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This request came from Github Open Source Secure and it's always welcome to clarify the policy
|
Review requested:
|
marco-ippolito
approved these changes
Mar 12, 2025
legendecas
reviewed
Mar 12, 2025
| @@ -106,6 +106,10 @@ a security vulnerability. Examples of unwanted actions are polluting globals, | |||
| causing an unrecoverable crash, or any other unexpected side effects that can | |||
| lead to a loss of confidentiality, integrity, or availability. | |||
|
|
|||
| For example, if trusted input (like secure application code) is correct, | |||
| then untrusted input must not lead to arbitrary JavaScript code execution or | |||
| escape the sandbox. | |||
There was a problem hiding this comment.
Is the term "sandbox" appropriate in this security context?
https://github.com/nodejs/node/blob/main/doc/contributing/security-model-strategy.md#document-the-security-model stated that Node.js is not a sandbox.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This request came from Github Open Source Secure and it's always welcome to clarify the policy