fs: only show deprecation warning when error code matches

[aduh95]

The deprecation is only for invalid types, it could be confusing the warning show up for an unrelated error.

Refs: #55753

[BridgeAR]

I believe all Node.js errors should trigger the warning and only programmer errors in Node.js code should not be caught. Is that correct? We don't yet have such utility method to check that. We could however check for any error code existence. It should not exist on regular programmer errors.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.16%. Comparing base (529b56e) to head (6f62176).
Report is 394 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #56549   +/-   ##
=======================================
  Coverage   89.16%   89.16%           
=======================================
  Files         662      662           
  Lines      191746   191746           
  Branches    36902    36901    -1     
=======================================
+ Hits       170970   170972    +2     
  Misses      13632    13632           
+ Partials     7144     7142    -2     

Files with missing lines	Coverage Δ
lib/fs.js	98.30% <100.00%> (ø)

... and 24 files with indirect coverage changes

[aduh95]

I believe all Node.js errors should trigger the warning and only programmer errors in Node.js code should not be caught. Is that correct? We don't yet have such utility method to check that. We could however check for any error code existence. It should not exist on regular programmer errors.

IMO that's a separate issue (IIUC you're complaining about the fact we blindly catch any error, instead of rethrowing non-Node.js ones). What this PR is addressing is that the warning should only appear when there's a ARG_TYPE error (as that's what has been deprecated).

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/65443/

[bjohansebas]

LGTM

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/65456/

[nodejs-github-bot]

Landed in 48f381d