Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: update test-set-http-max-http-headers to use node:test #56439

Merged
merged 1 commit into from
Jan 4, 2025
Merged

test: update test-set-http-max-http-headers to use node:test #56439

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 8 additions & 29 deletions test/parallel/test-set-http-max-http-headers.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,17 +4,10 @@ const common = require('../common');
const assert = require('assert');
const { spawn } = require('child_process');
const path = require('path');
const { suite, test } = require('node:test');
const testName = path.join(__dirname, 'test-http-max-http-headers.js');

const timeout = common.platformTimeout(100);

const tests = [];

function test(fn) {
tests.push(fn);
}

test(function(cb) {
test(function(_, cb) {
console.log('running subtest expecting failure');

// Validate that the test fails if the max header size is too small.
Expand All @@ -30,7 +23,7 @@ test(function(cb) {
}));
});

test(function(cb) {
test(function(_, cb) {
console.log('running subtest expecting success');

const env = Object.assign({}, process.env, {
Expand All @@ -54,13 +47,13 @@ test(function(cb) {
}));
});

// Next, repeat the same checks using NODE_OPTIONS if it is supported.
if (!process.config.variables.node_without_node_options) {
const skip = process.config.variables.node_without_node_options;
suite('same checks using NODE_OPTIONS if it is supported', { skip }, () => {
const env = Object.assign({}, process.env, {
NODE_OPTIONS: '--max-http-header-size=1024'
});

test(function(cb) {
test(function(_, cb) {
console.log('running subtest expecting failure');

// Validate that the test fails if the max header size is too small.
Expand All @@ -74,7 +67,7 @@ if (!process.config.variables.node_without_node_options) {
}));
});

test(function(cb) {
test(function(_, cb) {
// Validate that the test now passes if the same limit is large enough.
const args = ['--expose-internals', testName, '1024'];
const cp = spawn(process.execPath, args, { env, stdio: 'inherit' });
Expand All @@ -85,18 +78,4 @@ if (!process.config.variables.node_without_node_options) {
cb();
}));
});
}

function runTest() {
const fn = tests.shift();

if (!fn) {
return;
}

fn(() => {
setTimeout(runTest, timeout);
});
}

runTest();
});
Loading