Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf_hooks: remove useless calls in Histogram #41579

Closed
wants to merge 2 commits into from
+16 −16
Closed

perf_hooks: remove useless calls in Histogram #41579

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
54066bd
perf_hooks: remove useless calls in Histogram
mhdawson Jan 18, 2022
1b095d3
squash: address comments
mhdawson Jan 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
squash: address comments 
Signed-off-by: Michael Dawson <[email protected]>
@mhdawson
mhdawson committed Jan 26, 2022
commit 1b095d38fa3e308aea423d91e66e444bab840546
32 changes: 16 additions & 16 deletions src/histogram.cc
View file
Original file line number Diff line number Diff line change
@@ -159,10 +159,10 @@ void HistogramBase::GetPercentiles(const FunctionCallbackInfo<Value>& args) {
CHECK(args[0]->IsMap());
Local<Map> map = args[0].As<Map>();
(*histogram)->Percentiles([map, env](double key, int64_t value) {
map->Set(
env->context(),
Number::New(env->isolate(), key),
Number::New(env->isolate(), static_cast<double>(value)));
USE(map->Set(
env->context(),
Number::New(env->isolate(), key),
Number::New(env->isolate(), static_cast<double>(value))));
});
}

@@ -174,10 +174,10 @@ void HistogramBase::GetPercentilesBigInt(
CHECK(args[0]->IsMap());
Local<Map> map = args[0].As<Map>();
(*histogram)->Percentiles([map, env](double key, int64_t value) {
map->Set(
env->context(),
Number::New(env->isolate(), key),
BigInt::New(env->isolate(), value));
USE(map->Set(
env->context(),
Number::New(env->isolate(), key),
BigInt::New(env->isolate(), value)));
});
}

@@ -589,10 +589,10 @@ void IntervalHistogram::GetPercentiles(
CHECK(args[0]->IsMap());
Local<Map> map = args[0].As<Map>();
(*histogram)->Percentiles([map, env](double key, int64_t value) {
map->Set(
env->context(),
Number::New(env->isolate(), key),
Number::New(env->isolate(), static_cast<double>(value)));
USE(map->Set(
env->context(),
Number::New(env->isolate(), key),
Number::New(env->isolate(), static_cast<double>(value))));
});
}

@@ -604,10 +604,10 @@ void IntervalHistogram::GetPercentilesBigInt(
CHECK(args[0]->IsMap());
Local<Map> map = args[0].As<Map>();
(*histogram)->Percentiles([map, env](double key, int64_t value) {
map->Set(
env->context(),
Number::New(env->isolate(), key),
BigInt::New(env->isolate(), value));
USE(map->Set(
env->context(),
Number::New(env->isolate(), key),
BigInt::New(env->isolate(), value)));
});
}