Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc cleanup of node_report_utils.cc #25960

Merged
merged 3 commits into from
Feb 8, 2019
+12 −22
Merged

Misc cleanup of node_report_utils.cc #25960

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e49040b
report: remove empty string stream insertion
cjihrig Feb 6, 2019
4b4d465
report: remove unnecessary case block scopes
cjihrig Feb 6, 2019
39171d7
report: widen scope of #ifndef
cjihrig Feb 6, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
report: remove empty string stream insertion 
PR-URL: #25960
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
  • Loading branch information
@cjihrig
cjihrig committed Feb 8, 2019
commit e49040bd11fb4138e64f7a13dfa0e191eb58c251
7 changes: 2 additions & 5 deletions src/node_report_utils.cc
View file
Original file line number Diff line number Diff line change
@@ -144,11 +144,8 @@ void WalkHandle(uv_handle_t* h, void* arg) {
case UV_SIGNAL: {
// SIGWINCH is used by libuv so always appears.
// See http://docs.libuv.org/en/v1.x/signal.html
data << "signum: " << handle->signal.signum
#ifndef _WIN32
<< " (" << node::signo_string(handle->signal.signum) << ")"
#endif
<< "";
data << "signum: " << handle->signal.signum << " (" <<
node::signo_string(handle->signal.signum) << ")";
break;
}
default: