Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Net test asserts #23534

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test: Reorder asserts arguments
Revert arguments for assert and ensure that the first
argument is always the actual value being tested
  • Loading branch information
frony committed Oct 12, 2018
commit 17a66d76956c63aa5cf5aa12307fd3038fc95e06
4 changes: 2 additions & 2 deletions test/pummel/test-net-pause.js
Original file line number Diff line number Diff line change
@@ -53,7 +53,7 @@ server.on('listening', function() {
setTimeout(function() {
chars_recved = recv.length;
console.log(`pause at: ${chars_recved}`);
assert.strictEqual(true, chars_recved > 1);
assert.strictEqual(chars_recved > 1, true);
client.pause();
setTimeout(function() {
console.log(`resume at: ${chars_recved}`);
@@ -86,6 +86,6 @@ server.on('listening', function() {
server.listen(common.PORT);

process.on('exit', function() {
assert.strictEqual(N, recv.length);
assert.strictEqual(recv.length, N);
console.error('Exit');
});