Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test on unhandled rejection #17228

Closed
wants to merge 1 commit into from
Closed

Add test on unhandled rejection #17228

wants to merge 1 commit into from

Conversation

LarryLuTW
Copy link
Contributor

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Nov 22, 2017
@MylesBorins
Copy link
Contributor

hey @Larry850806

would you be able to merge all of your changes into a single commit?

MylesBorins
MylesBorins approved these changes Nov 22, 2017
View reviewed changes
Copy link
Contributor

@MylesBorins MylesBorins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. LGTM

@MylesBorins
Copy link
Contributor

CI: https://ci.nodejs.org/job/node-test-pull-request/11615/

@gireeshpunathil gireeshpunathil added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 22, 2017
@mscdex mscdex added the async_hooks Issues and PRs related to the async hooks subsystem. label Nov 22, 2017
@jasnell
Copy link
Member

jasnell commented Nov 22, 2017

This has some linting issues (it needs a semi-colon)

The CI failure on windows appears unrelated.

@jasnell
Copy link
Member

jasnell commented Nov 22, 2017

Fixing the linting issue on landing.

jasnell pushed a commit that referenced this pull request Nov 22, 2017
@LarryLuTW @jasnell
test: add test on unhandled rejection
18cf096 
PR-URL: #17228
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@jasnell
Copy link
Member

jasnell commented Nov 22, 2017

Landed in 18cf096 with the lint nit fixed. Congrats on your PR to core!

@jasnell jasnell closed this Nov 22, 2017
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
@LarryLuTW @MylesBorins
test: add test on unhandled rejection
176229f 
PR-URL: #17228
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
@LarryLuTW @MylesBorins
test: add test on unhandled rejection
2d2e780 
PR-URL: #17228
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Dec 12, 2017
Merged
gibfahn pushed a commit that referenced this pull request Dec 19, 2017
@LarryLuTW @gibfahn
test: add test on unhandled rejection
5125e6c 
PR-URL: #17228
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@gibfahn gibfahn mentioned this pull request Dec 20, 2017
Closed
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
@LarryLuTW @gibfahn
test: add test on unhandled rejection
b4726fa 
PR-URL: #17228
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@gibfahn gibfahn mentioned this pull request Dec 20, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@MylesBorins MylesBorins MylesBorins approved these changes

@cjihrig cjihrig cjihrig approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

Assignees
No one assigned
Labels
async_hooks Issues and PRs related to the async hooks subsystem. code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@LarryLuTW @MylesBorins @jasnell @cjihrig @gireeshpunathil @mscdex @gibfahn @nodejs-github-bot