-
Notifications
You must be signed in to change notification settings - Fork 30.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
http: make early hints implementation more generic #44816
Labels
good first issue
Issues that are suitable for first-time contributors.
http
Issues or PRs related to the http subsystem.
Comments
I'm working on this task, and will open a pull request soon. |
Can a link header be a string and an array just like the parameter type of For example should both of them be valid? response.writeEarlyHints({
link: ['</styles.css>; rel=preload; as=style']
}) response.writeEarlyHints({
link: '</styles.css>; rel=preload; as=style'
}) |
Yes |
2 tasks
nodejs-github-bot
pushed a commit
that referenced
this issue
Oct 6, 2022
PR-URL: #44820 Fixes: #44816 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]>
danielleadams
pushed a commit
that referenced
this issue
Oct 11, 2022
PR-URL: #44820 Fixes: #44816 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
good first issue
Issues that are suitable for first-time contributors.
http
Issues or PRs related to the http subsystem.
In #44180, we thought that the "early hints" implementation is not complete as it landed.
We need to fix it either as:
or
The text was updated successfully, but these errors were encountered: