Skip to content

tracking issue: full VS2017 support #13052

Closed
@refack

Description

@refack
Contributor
  • Version: *
  • Platform: Windows
  • Subsystem: *

Tracking issue

Goal: get node compiling with VS2017 and passing all tests

breakdown of CI task by @joaocgreis:

Activity

self-assigned this
on May 16, 2017
added
buildIssues and PRs related to build files or the CI.
toolsIssues and PRs related to the tools directory.
windowsIssues and PRs related to the Windows platform.
on May 16, 2017
refack

refack commented on May 16, 2017

@refack
ContributorAuthor

/cc @nodejs/lts is it a goal for porting? (re: #12450 (comment) and following comments)

joaocgreis

joaocgreis commented on May 16, 2017

@joaocgreis
Member

create CI target

I'm going to move forward with that.

pass all tests

I ran the tests with master when we started adding support and everything passed. Didn't try recently though. Re #12450 (comment), can you paste the errors you get here?

refack

refack commented on May 16, 2017

@refack
ContributorAuthor

I guess there's something wonky with symlinks on my machine.

parallel\test-module-circular-symlinks
Path: parallel/test-module-circular-symlinks
assert.js:92
  throw new AssertionError({
  ^

AssertionError [ERR_ASSERTION]: false == true
    at Object.<anonymous> (d:\code\node-cur\test\parallel\test-module-circular-symlinks.js:68:8)
    at Module._compile (module.js:569:30)
    at Object.Module._extensions..js (module.js:580:10)
    at Module.load (module.js:503:32)
    at tryModuleLoad (module.js:466:12)
    at Function.Module._load (module.js:458:3)
    at Function.Module.runMain (module.js:605:10)
    at startup (bootstrap_node.js:144:16)
    at bootstrap_node.js:561:3
Command: d:\code\node-cur\Release\node.exe d:\code\node-cur\test\parallel\test-module-circular-symlinks.js
sequential\test-benchmark-http
...

http\http_server_for_chunky_client.js
http\_chunky_http_client.js type="send" n=1 len=1: 105.496705390639

http\simple.js
Command: d:\code\node-cur\Release\node.exe d:\code\node-cur\test\sequential\test-benchmark-http.js
--- TIMEOUT ---
addons/symlinked-module/test
Path: addons/symlinked-module/test
module.js:598
  return process.dlopen(module, path._makeLong(filename));
                 ^

Error: Module did not self-register.
    at Object.Module._extensions..node (module.js:598:18)
    at Module.load (module.js:503:32)
    at tryModuleLoad (module.js:466:12)
    at Function.Module._load (module.js:458:3)
    at Module.require (module.js:513:17)
    at require (internal/module.js:11:18)
    at __dirname.forEach (d:\code\node-cur\test\addons\symlinked-module\test.js:30:15)
    at Array.forEach (native)
    at Object.<anonymous> (d:\code\node-cur\test\addons\symlinked-module\test.js:29:24)
    at Module._compile (module.js:569:30)
Command: d:\code\node-cur\Release\node.exe d:\code\node-cur\test\addons\symlinked-module\test.js
joaocgreis

joaocgreis commented on May 23, 2017

@joaocgreis
Member

Added VS2017 to node-test-commit-windows-fanned, but only for Node >= version 8 and onlly for the compiling stage (i.e., not for testing addons, that is blocked until npm is updated with a recent version of node-gyp).

Current status:

refack

refack commented on May 23, 2017

@refack
ContributorAuthor

Added VS2017 to node-test-commit-windows-fanned

@joaocgreis 👍
I copied your list into the first comment.

sam-github

sam-github commented on Sep 19, 2017

@sam-github
Contributor

What is the specific question that is on the LTS agenda for this issue?

42 remaining items

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    buildIssues and PRs related to build files or the CI.toolsIssues and PRs related to the tools directory.windowsIssues and PRs related to the Windows platform.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @sam-github@refack@joaocgreis@gibfahn

        Issue actions

          tracking issue: full VS2017 support · Issue #13052 · nodejs/node