Skip to content

Remove nonstandard WHATWG URL url.toString(true) #10750

Closed
@domenic

Description

@domenic
Contributor

As with originFor and friends, it should ideally move to a separate export on the url module, instead of extending the standard object with unspecified behavior.

Activity

added
whatwg-urlIssues and PRs related to the WHATWG URL implementation.
on Jan 12, 2017
jasnell

jasnell commented on Jan 12, 2017

@jasnell
Member

definitely agree that this is not ideal. I would like to have a way of getting back the unicode/idna encoding of the URL without punycode tho so moving something into the url module makes sense.... although it is a bit annoying

joyeecheung

joyeecheung commented on Jan 22, 2017

@joyeecheung
Member

Just noticed #10857 is gonna fix this (although TupleOrigin .toString() still has an unspecified argument).

TimothyGu

TimothyGu commented on Feb 2, 2017

@TimothyGu
Member

Fixed in c5e9654...0d9ea4f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Remove nonstandard WHATWG URL url.toString(true) · Issue #10750 · nodejs/node