Skip to content

Regression in Jest with jsdom #10492

Closed
Closed
@cpojer

Description

@cpojer
  • Version: 7.3.0
  • Platform: mac os

Repro:

Two tests will fail on 7.3.0 that did not fail using 7.2.0. The concrete bug is when using --env=jsdom with Jest, console.log calls from a jsdom's vm context will not be printed any more for some reason. There is a PR in Jest to fix this: jestjs/jest#2457 but I'd like to first understand what regression in node caused this and whether this is a bug in node or an expected change.

Failed tests that expect "console.log" output to be present with the jsdom environment:
screen shot 2016-12-29 at 12 59 28 am

Activity

added
consoleIssues and PRs related to the console subsystem.
on Dec 28, 2016
MylesBorins

MylesBorins commented on Dec 28, 2016

@MylesBorins
Contributor

I'm bisecting to figure out what is going on here. Will post updates in the comment as edits

edit 1:

Looks like the commit that broke everything was 524f693

the original PR: #10227

/cc @bnoordhuis

added
vmIssues and PRs related to the vm subsystem.
on Dec 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    consoleIssues and PRs related to the console subsystem.vmIssues and PRs related to the vm subsystem.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @cpojer@MylesBorins@addaleax@italoacasas

        Issue actions

          Regression in Jest with jsdom · Issue #10492 · nodejs/node