Closed
Description
- Version: 7.3.0
- Platform: mac os
Repro:
- clone https://github.com/facebook/jest
- yarn install
./jest
Two tests will fail on 7.3.0 that did not fail using 7.2.0. The concrete bug is when using --env=jsdom
with Jest, console.log
calls from a jsdom's vm context will not be printed any more for some reason. There is a PR in Jest to fix this: jestjs/jest#2457 but I'd like to first understand what regression in node caused this and whether this is a bug in node or an expected change.
Failed tests that expect "console.log" output to be present with the jsdom environment:
Metadata
Metadata
Assignees
Type
Projects
Milestone
Relationships
Development
No branches or pull requests
Activity
MylesBorins commentedon Dec 28, 2016
I'm bisecting to figure out what is going on here. Will post updates in the comment as edits
edit 1:
Looks like the commit that broke everything was 524f693
the original PR: #10227
/cc @bnoordhuis
Revert "src: don't overwrite non-writable vm globals"
Revert "src: don't overwrite non-writable vm globals"
Revert "src: don't overwrite non-writable vm globals"
Revert "src: don't overwrite non-writable vm globals"