Commit 2e568d9
File tree
8 files changed
+15
-15
lines changed- lib
- internal
8 files changed
+15
-15
lines changedOriginal file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
661 | 661 |
| |
662 | 662 |
| |
663 | 663 |
| |
664 |
| - | |
| 664 | + | |
665 | 665 |
| |
666 | 666 |
| |
667 | 667 |
| |
668 | 668 |
| |
669 | 669 |
| |
670 |
| - | |
671 |
| - | |
| 670 | + | |
| 671 | + | |
672 | 672 |
| |
673 | 673 |
| |
674 | 674 |
| |
|
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
26 | 26 |
| |
27 | 27 |
| |
28 | 28 |
| |
29 |
| - | |
| 29 | + | |
30 | 30 |
| |
31 | 31 |
| |
32 | 32 |
| |
|
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
24 | 24 |
| |
25 | 25 |
| |
26 | 26 |
| |
27 |
| - | |
| 27 | + | |
28 | 28 |
| |
29 | 29 |
| |
30 | 30 |
| |
|
+4-4
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
210 | 210 |
| |
211 | 211 |
| |
212 | 212 |
| |
213 |
| - | |
| 213 | + | |
214 | 214 |
| |
215 | 215 |
| |
216 | 216 |
| |
| |||
221 | 221 |
| |
222 | 222 |
| |
223 | 223 |
| |
224 |
| - | |
| 224 | + | |
225 | 225 |
| |
226 | 226 |
| |
227 | 227 |
| |
228 | 228 |
| |
229 | 229 |
| |
230 | 230 |
| |
231 | 231 |
| |
232 |
| - | |
| 232 | + | |
233 | 233 |
| |
234 | 234 |
| |
235 | 235 |
| |
| |||
345 | 345 |
| |
346 | 346 |
| |
347 | 347 |
| |
348 |
| - | |
| 348 | + | |
349 | 349 |
| |
350 | 350 |
| |
351 | 351 |
| |
|
+3-3
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
345 | 345 |
| |
346 | 346 |
| |
347 | 347 |
| |
348 |
| - | |
| 348 | + | |
349 | 349 |
| |
350 | 350 |
| |
351 | 351 |
| |
| |||
1078 | 1078 |
| |
1079 | 1079 |
| |
1080 | 1080 |
| |
1081 |
| - | |
| 1081 | + | |
1082 | 1082 |
| |
1083 |
| - | |
| 1083 | + | |
1084 | 1084 |
| |
1085 | 1085 |
| |
1086 | 1086 |
| |
|
+1-1
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
100 | 100 |
| |
101 | 101 |
| |
102 | 102 |
| |
103 |
| - | |
| 103 | + | |
104 | 104 |
| |
105 | 105 |
| |
106 | 106 |
| |
|
+1-1
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
30 | 30 |
| |
31 | 31 |
| |
32 | 32 |
| |
33 |
| - | |
| 33 | + | |
34 | 34 |
| |
35 | 35 |
| |
36 | 36 |
| |
|
+1-1
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
60 | 60 |
| |
61 | 61 |
| |
62 | 62 |
| |
63 |
| - | |
| 63 | + | |
64 | 64 |
| |
65 | 65 |
| |
66 | 66 |
| |
|
4 commit comments
shedinnmarble commentedon Oct 5, 2016
can you tell me why you change from let to var? I think there are no difference in this case
addaleax commentedon Oct 5, 2016
@xiangdewei You’re right, there is no difference in behaviour here. But – I know it sounds weird – using
let
is a bit slower right now, and given how performance-aware Node.js core tries to be, it makes sense to avoid it at least in loops.MylesBorins commentedon Oct 5, 2016
as @addaleax mentioned this is about how the V8 engine optimizes loops. There is a slight deopt when using let in a for loop rather than var. This is more noticeable in hot code. The update to
punycode
made a difference of 5%, which is non-trivialshedinnmarble commentedon Oct 6, 2016
@addaleax @thealphanerd now I know it's about the performance, thank you