Skip to content

fix: sort impacted versions DESC #885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 15, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 26 additions & 23 deletions lib/security_blog.js
Original file line number Diff line number Diff line change
Expand Up @@ -281,34 +281,37 @@ export default class SecurityBlog extends SecurityRelease {
}

getImpact(content) {
const impact = content.reports.reduce((acc, report) => {
for (const affectedVersion of report.affectedVersions) {
if (acc[affectedVersion]) {
acc[affectedVersion].push(report);
} else {
acc[affectedVersion] = [report];
}
const impact = new Map();
for (const report of content.reports) {
for (const version of report.affectedVersions) {
if (!impact.has(version)) impact.set(version, []);
impact.get(version).push(report);
}
return acc;
}, {});

const impactText = [];
for (const [key, value] of Object.entries(impact)) {
const groupedByRating = Object.values(_.groupBy(value, 'severity.rating'))
.map(severity => {
if (!severity[0]?.severity?.rating) {
this.cli.error(`severity.rating not found for the report ${severity[0].id}. \
Please add it manually before continuing.`);
}

const result = Array.from(impact.entries())
.sort(([a], [b]) => b.localeCompare(a)) // DESC
.map(([version, reports]) => {
const severityCount = new Map();

for (const report of reports) {
const rating = report.severity.rating?.toLowerCase();
if (!rating) {
this.cli.error(`severity.rating not found for report ${report.id}.`);
process.exit(1);
}
const firstSeverityRating = severity[0].severity.rating.toLocaleLowerCase();
return `${severity.length} ${firstSeverityRating} severity issues`;
}).join(', ');
severityCount.set(rating, (severityCount.get(rating) || 0) + 1);
}

impactText.push(`The ${key} release line of Node.js is vulnerable to ${groupedByRating}.`);
}
const groupedByRating = Array.from(severityCount.entries())
.map(([rating, count]) => `${count} ${rating} severity issues`)
.join(', ');

return `The ${version} release line of Node.js is vulnerable to ${groupedByRating}.`;
})
.join('\n');

return impactText.join('\n');
return result;
}

getVulnerabilities(content) {
Expand Down
Loading