fix: correct username and token validation #613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #613 +/- ##
==========================================
+ Coverage 84.10% 84.15% +0.05%
==========================================
Files 37 37
Lines 4051 4064 +13
==========================================
+ Hits 3407 3420 +13
Misses 644 644
Continue to review full report at Codecov.
|
richardlau
reviewed
Mar 19, 2022
lib/auth.js
Outdated
| if (typeof username !== 'string') { | ||
| errorExit(`username must be a string, received ${typeof username}`); | ||
| } | ||
| if (!/^[a-zA-Z0-9]+$/.test(username)) { |
There was a problem hiding this comment.
These are GitHub usernames, aren't they? They're allowed to contain hyphens, at least according to https://github.com/join:
There was a problem hiding this comment.
I added hyphens as a permissible character.
Trott
commented
Mar 19, 2022
Trott
commented
Mar 19, 2022
richardlau
approved these changes
Mar 19, 2022
The current username and token validation regular expressions will match any string. This adds tests and fixes the regular expressions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current username and token validation regular expressions will match
any string. This adds tests and fixes the regular expressions.