refactor(cli): apply optimizations #574
Merged
+19
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #574 +/- ##
==========================================
- Coverage 82.57% 82.41% -0.17%
==========================================
Files 35 35
Lines 1750 1751 +1
==========================================
- Hits 1445 1443 -2
- Misses 305 308 +3
Continue to review full report at Codecov.
|
codebytere
approved these changes
Oct 26, 2021
targos
approved these changes
Oct 26, 2021
• List the available types by a `ListFormat` formatter. • Replace unnecessary conditional check. • Use switch statement for better readablity and performance. • Avoid casting strings to strings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
• List the available types by a
ListFormatformatter.• Replace unnecessary conditional check.
• Use switch statement for better readablity and performance.
• Avoid casting strings to strings.