ncu-team: new tool to sync members of a Github team #164
+458
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #164 +/- ##
==========================================
- Coverage 94.5% 93.69% -0.81%
==========================================
Files 16 18 +2
Lines 600 666 +66
==========================================
+ Hits 567 624 +57
- Misses 33 42 +9
Continue to review full report at Codecov.
|
priyank-p
reviewed
Feb 6, 2018
lib/team_info.js
Outdated
| } | ||
|
|
||
| if (blocks.size === 0) { | ||
| throw new Error(`Could not find block matching ${RE}`); |
There was a problem hiding this comment.
Can we instead log out the comments instead here i guess the regular expression would be kind of daunting to log out to user?
priyank-p
approved these changes
Feb 7, 2018
priyank-p
reviewed
Feb 7, 2018
| team(slug: $team) { | ||
| name, | ||
| description, | ||
| members(first: 100) { |
There was a problem hiding this comment.
Does this limit how many team members we receive?
There was a problem hiding this comment.
@cPhost Yeah, I plan to fix that in a later PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.