feat: run Node.js markdown formatter on markdown output #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trott
force-pushed
the
formatter
branch
2 times, most recently
from
555b60e to
1370f4c
Compare
|
Lockfile has conflicts after I merged your other PRs |
Closed
To increase the probability of producing markdown that will pass the Node.js linter, use the Node.js linter to format markdown output.
|
Lockfile conflicts resolved. |
targos
approved these changes
Oct 10, 2021
|
@targos Can we land this and push out a new release? It would have been great to have this available for the release tomorrow, but at least we can get it in for the next one? |
Oh, wait, at least in theory, you're not a member of this repository any more than I am. I just checked and the collaborators or Fishrock, rvagg, Myles, and XhmikosR. Could probably stand to update the collaborators. Anyway, I'll go ahead and land this at least. |
|
Oh, I thought this repo belonged to the Release WG. |
It probably should. That was my assumption too! |
github-actions bot
pushed a commit
that referenced
this pull request
Oct 14, 2021
## [2.7.0](v2.6.0...v2.7.0) (2021-10-14) ### Features * run Node.js markdown formatter on markdown output ([#98](#98)) ([26afb81](26afb81)) ### Bug Fixes * main instead of master ([c6aac22](c6aac22)) * remove build step from release process ([ec2b9c0](ec2b9c0)) ### Trivial Changes * add auto-release workflow ([36ca9e5](36ca9e5)) * add dependabot config ([5f16f7e](5f16f7e)) * **deps:** bump remark-preset-lint-node from 3.2.0 to 3.3.0 ([ed6ff3b](ed6ff3b)) * **deps:** bump remark-stringify from 10.0.0 to 10.0.1 ([73c2046](73c2046)) * escape opening bracket explicitly ([#97](#97)) ([64c1220](64c1220)), closes [/github.com/nodejs/node/pull/40388#issuecomment-939321694](https://github.com/nodejs//github.com/nodejs/node/pull/40388/issues/issuecomment-939321694) * update package-lock.json ([#102](#102)) ([24112e0](24112e0)) * update standard (and path-parse) ([#96](#96)) ([66b6eef](66b6eef)) * update test workflow ([#100](#100)) ([eaeb938](eaeb938))
|
🎉 This PR is included in version 2.7.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Closed
renawolford6
added a commit
to renawolford6/changelog-maker-javascript
that referenced
this pull request
Nov 9, 2022
## [2.7.0](nodejs/changelog-maker@v2.6.0...v2.7.0) (2021-10-14) ### Features * run Node.js markdown formatter on markdown output ([#98](nodejs/changelog-maker#98)) ([26afb81](nodejs/changelog-maker@26afb81)) ### Bug Fixes * main instead of master ([c6aac22](nodejs/changelog-maker@c6aac22)) * remove build step from release process ([ec2b9c0](nodejs/changelog-maker@ec2b9c0)) ### Trivial Changes * add auto-release workflow ([36ca9e5](nodejs/changelog-maker@36ca9e5)) * add dependabot config ([5f16f7e](nodejs/changelog-maker@5f16f7e)) * **deps:** bump remark-preset-lint-node from 3.2.0 to 3.3.0 ([ed6ff3b](nodejs/changelog-maker@ed6ff3b)) * **deps:** bump remark-stringify from 10.0.0 to 10.0.1 ([73c2046](nodejs/changelog-maker@73c2046)) * escape opening bracket explicitly ([#97](nodejs/changelog-maker#97)) ([64c1220](nodejs/changelog-maker@64c1220)), closes [/github.com/nodejs/node/pull/40388#issuecomment-939321694](https://github.com/nodejs//github.com/nodejs/node/pull/40388/issues/issuecomment-939321694) * update package-lock.json ([#102](nodejs/changelog-maker#102)) ([24112e0](nodejs/changelog-maker@24112e0)) * update standard (and path-parse) ([#96](nodejs/changelog-maker#96)) ([66b6eef](nodejs/changelog-maker@66b6eef)) * update test workflow ([#100](nodejs/changelog-maker#100)) ([eaeb938](nodejs/changelog-maker@eaeb938))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To increase the probability of producing markdown that will pass the
Node.js linter, use the Node.js linter to format markdown output.