test/arm reported as failure when it passed for a PR

[targos]

Examples:

• tools: forbid template literals in assert.throws node#10301
• url: make WHATWG URL implementation more spec compliant node#10317

[gibfahn]

Hmm, this is still happening, nodejs/node#10517 (https://ci.nodejs.org/job/node-test-commit/6915/) for a CI run that's still in Jenkins.

[jbergstroem]

Can confirm. The jenkins script for notifying is likely to blame and I've looked at it a few times; can't quite figure it out. Still on it.

[joaocgreis]

Should be fixed. It was running the two scripts (for success and failure) unconditionally, so it would mark it as success and immediately mark it as failure. I tested with a success, I don't have a PR that fails to test.

[joaocgreis]

AIX was reporting success when the job fails, so I changed it as well but did not test (cc @mhdawson)

[mhdawson]

To test on AIX is what we we need a PR that fails on AIX, and we run the CI job with the results posted to the PR and we then validate that it shows as failed ?

[gibfahn]

I've confirmed that the AIX reporting is fixed.

Before/After Fix	PR	CI Job	PR Reported	CI Reported
Before	11852	8483	💚	🔴
After	9163	8493	🔴	🔴
After	11856	8495	💚	💚

[joaocgreis]

@gibfahn thanks!