-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: misc updates #132
fix: misc updates #132
Conversation
This comment has been minimized.
This comment has been minimized.
fyi, i tested node's own blob against the WPT, it had some things that was failing... |
node: engines | ||
- os: macOS-latest | ||
node: "14" | ||
node: ["17.3"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't we include the currently supported versions of Node.js here?
node: ["17.3"] | |
node: ["12.20.0", "14.13.0", "16.0.0", "17"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The http module loader API changed...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can revisit this later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one comment, otherwise LGTM 👍
The purpose of this PR is:
I original wanted to improve the .d.ts to better return the types from the async from utilities. but ended up doing more.
This is what has changed: