-
Notifications
You must be signed in to change notification settings - Fork 684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for LoongArch64 #2023
Conversation
Using a custom docker image
Hi @donmor Thanks for your contribution for LoongArch!
Does it need to cross compile for loongarch64 target on x86_64 host? Thanks, |
I think so but I failed to make it pass CI. I can build this locally on qemu vm, though <:-/ |
And I'm not sure if it is finely optimized. It's just a simpliest patch to build this package on loongarch. |
Could we skip CI and just add basic support like |
loongarch64 is already in tier2. This PR should get more attention. @asomers would you like to take a look? |
Seconded. The user base of this architecture is definitely picking up and |
@@ -105,6 +105,9 @@ task: | |||
- name: Linux i686 musl | |||
env: | |||
TARGET: i686-unknown-linux-musl | |||
- name: Linux LoongArch64 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add this here, Nix has switched to GitHub action for most CI checks:
Line 94 in 50e4283
powerpc64le-unknown-linux-gnu, |
Cross.toml
Outdated
[target.loongarch64-unknown-linux-gnu] | ||
image = "ghcr.io/loongarchlinux/archlinux:latest" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like Loongarch has been supported by cross, is this custom image still needed?
src/sys/ioctl/linux.rs
Outdated
@@ -41,6 +41,7 @@ mod consts { | |||
target_arch = "s390x", | |||
target_arch = "x86_64", | |||
target_arch = "aarch64", | |||
target_arch = "loongarch64", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you guys please check what are currently supported and what are not? And, if there is still a lot of work to do, and you guys don't mind, a tracking issue would be appreciated:)
The author of this PR hasn't been active on GitHub for a while, so feel free to pick it up. |
Triage: #2045 (since |
Matches nix-rust#2045
Natively supported
Thanks for confirming that!
Please also add this target to the target support list of Nix as a tier2 target. |
Sorry for be inactive (I'm busy at work). I have this rebased here (#2461 ). |
This is no longer needed, close it as superseded by #2461. |
Yet another architecture :-)
I don' know much about rust, but at least it built on qemu <:-/