Emit color job progress and job failure messages by default #1455
Conversation
Adds support for ANSI escape sequences used for colorization to the job status indicator, and updates `ElideMiddle()` to account for the non-obvious change in text width. As an example, the following will now emit the job status in green: env NINJA_STATUS="\\033[32m[%f/%t] \\033[0m" ninja; Invalid color escape codes are treated as plain text (as before). ANSI escape sequences apart from `\033...m` are not supported. Closes ninja-build#713. Closes ninja-build#912.
Set the default `NINJA_STATUS` and the "FAILED" text on job failure to use ANSI color code escapes if running under a smart terminal. Requires ninja-build#1454 to be merged first.
|
This is inherently subjective. We think the current default is a good default; it looks like you'll be able to set the env var to include color codes to get this locally soon. |
|
I don’t think it’s a subjective request at all. Ninja output for complicated jobs is a wall of text. It’s virtually impossible to find the end of one job and the start of another when scrolling back in the buffer. (And yes this is contingent on support for ANSI color escapes from either of the two PRs to add that.) The reason why the current default doesn’t have colors is because it was literally impossible before those PRa were merged, whether via a local environment variable or hard-coded in the code, due to the incorrect calculation of character widths. It is unfair to say “we probably got this right when there literally was no choice at the time of doing it differently. |
|
Eliding with ANSI escapes is slower (if done correctly, see WIP about this in #1494), that's why we're reluctant to change the default. You also can't use Coloring the "FAILED:" message does sound like a good idea to me though. |
|
@jhasse Thank you for providing legitimate reasons for not taking this. Do you want me to open a separate PR for the red failure messages or rebase this one for you guys to reopen? Also, what do you recommend in lieu of |
Open a new one.
There's |
Set the default
NINJA_STATUSand the "FAILED" text on job failure touse ANSI color code escapes if running under a smart terminal.
Requires #1454 to be merged first.