Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow disabling escape code stripping #1475

Closed
Boddlnagg opened this issue Oct 5, 2018 · 3 comments
Closed

Allow disabling escape code stripping #1475

Boddlnagg opened this issue Oct 5, 2018 · 3 comments
Milestone
1.9.0

Comments

@Boddlnagg
Copy link

There's this little TODO comment in the code that handles ANSI escape code stripping:

ninja/src/build.cc

Line 170 in 52c1d0c

// TODO: There should be a flag to disable escape code stripping.

This would be really useful to me, and I didn't find an open issue about it, so I'm opening this one.
@codyps
Copy link

codyps commented Oct 5, 2018

There is an existing PR to add that functionality: #1268

@ghost
Copy link

ghost commented Oct 17, 2018

Since 1.8.2 is still the latest ninja release, this fixed patch from a comment still works for me.

@mathstuf
Copy link
Contributor

See also #912 which is probably obsoleted by this support. It does have other fixes though, so I'll rebase it to pull out the useful fixes after another fix lands.

@jhasse jhasse closed this as completed in bf7107b Nov 13, 2018
@jhasse jhasse mentioned this issue Nov 20, 2018
Closed
mydongistiny pushed a commit to mydongistiny/ninja that referenced this issue Oct 1, 2019
@danw
Merge commit '5a78423193c48cae4800eb1ec44b62d14ae03920' into master
ee41acc 
This is a merge of upstream master up until this dep file parsing
change, which will need more verification given our depfiles:
  ninja-build#1039

The biggest change in this merge is probably the use of 64-bit
timestamps.

* commit '5a78423193c48cae4800eb1ec44b62d14ae03920': (80 commits)
  Add OSX build on travis (ninja-build#1502)
  Fit --help output into 80 columns and move verbose up, fix ninja-build#1500
  Improve error message when Python wasn't found for the browse tool
  Explain why there's no browse tool, fix ninja-build#1478
  HACKING: use `Python` for the project
  HACKING: fix some whitespace nits
  Fix rendering of code block, fix ninja-build#955
  Make -j 0 run unlimited parallel builds, fix ninja-build#1309
  Enable ANSI escape sequences on Windows 10 terminals
  Add --verbose as an alternative spelling for -v, fix ninja-build#1310
  Add unit test for ninja-build#1491
  Allow disabling of escape code stripping, fix ninja-build#1475
  subprocess-win32: add hint on ERROR_INVALID_PARAMETER
  Win32Fatal: support a "hint" for the error
  manual: mention the "invalid parameter" case
  util: don't add ellipses width when deciding if they're necessary
  Verify GetFullPathName return value
  Make output_test.py independent of the environment
  Fix older VS compatibility issues and PDB files generation issue. (ninja-build#1435)
  Fix parsing some special chars in depfiles
  ...

Change-Id: I315385cecc748ff351614792a9921ec87e5f4cf3
@jhasse jhasse added this to the 1.9.0 milestone May 11, 2021
@mohrr mohrr mentioned this issue May 17, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.9.0
Development

No branches or pull requests
4 participants
@jhasse @mathstuf @codyps @Boddlnagg