Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make group member list a BTreeSet #16

Merged
merged 1 commit into from
Feb 1, 2025
Merged

Conversation

Mic92
Copy link
Contributor

@Mic92 Mic92 commented Feb 1, 2025

vec::dedup() won't work if the input is not sorted.

vec::dedup() won't work if the input is not sorted.
@@ -440,7 +438,7 @@ mod tests {
let expected_group = expect![[r#"
root:x:0:root
initial:x:998:initial
wheel:x:999:normalo,initial
wheel:x:999:initial,normalo
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those has to be sorted now. But I have to say having reproducible order in this file is nicer anyway.

@Mic92 Mic92 changed the title make group member list a hashset make group member list a BTreeSet Feb 1, 2025
Copy link
Owner

@nikstur nikstur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, this is definitely the way to go!

@nikstur nikstur merged commit f0ec54a into nikstur:main Feb 1, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants