refactor!: Drop clickOutsideOptions mixin and refactor using components
#6429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
added
3. to review
susnux
requested review from
st3iny,
raimund-schluessler,
ShGKme and
Antreesy
Is it required to remove the mixin? If not, could we separate PR with mixing removing and component rewriting? |
susnux
commented
Jan 23, 2025
No but the refactor is needed before removal. So after that it is not needed anymore, so we can do it directly. |
susnux
force-pushed
the
refactor/next
branch
from
6655a57 to
8504bed
Compare
ShGKme
approved these changes
Feb 28, 2025
…ents Following components which used the mixin were refactored to not need it anymore. Also refactored to use `<script setup>` with proper Typescript types and slot definitions. - `NcHeaderMenu` - `NcAppNavigationSettings` Co-authored-by: Ferdinand Thiessen <[email protected]> Co-authored-by: Grigorii K. Shartsev <[email protected]> Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
force-pushed
the
refactor/next
branch
from
43aae91 to
c7d40e9
Compare
Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
force-pushed
the
refactor/next
branch
from
2564fa3 to
e6a462a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@nextcloud/vue v9breaking changes #6384☑️ Resolves
clickOutsideOptionsmixin and refactor using components.<script setup>with proper Typescript types and slot definitions.NcHeaderMenuNcAppNavigationSettings🏁 Checklist
nextrequested with a Vue 3 upgrade