fix(NcPopover): emit after-show after focus-trap init to correctly return focus when content set focus initially (e.g. NcEmojiPicker)
#6342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Grigorii K. Shartsev <[email protected]>
`after-show` was triggered before the end of init, including focusing on the elements using `focus-trap`. This broke `focus-trap` auto return focus when `NcPopover` content focused an element on `after-show`, making it the element to return focus to. Same for `after-hide`. Signed-off-by: Grigorii K. Shartsev <[email protected]>
ShGKme
added
bug
|
/backport to next |
ShGKme
added
feature: popover
9 tasks
susnux
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
after-showwas triggered before the end of init, including focusing on the elements usingfocus-trap.This broke
focus-trapauto return focus whenNcPopovercontent focused an element onafter-show, making it the element to return focus to.Same for
after-hide.Additionally, fixed types of related
setReturnFocus, which allows function🖼️ Screenshots
body🏁 Checklist
nextrequested with a Vue 3 upgrade