Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[next] feat(NcButton): Allow to specify target attribute for buttons with href #5939

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Aug 7, 2024

Backport of #5938

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Amend HEAD commit to remove the line stating to skip CI

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot backportbot bot requested review from juliusknorr, ShGKme and mejo- August 7, 2024 15:21
@backportbot backportbot bot added enhancement New feature or request 3. to review Waiting for reviews feature: button labels Aug 7, 2024
…href

Required to allow opening links in `_blank` target via `NcButton`.

Signed-off-by: Jonas <[email protected]>
@susnux susnux force-pushed the backport/5938/next branch from c4b8345 to b553e36 Compare August 29, 2024 22:39
@susnux susnux marked this pull request as ready for review August 29, 2024 22:39
@susnux susnux modified the milestones: 8.17.1, 9.0.0-alpha.6 Aug 29, 2024
@susnux susnux merged commit 238679f into next Aug 30, 2024
21 checks passed
@susnux susnux deleted the backport/5938/next branch August 30, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement New feature or request feature: button
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants