Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable ML inference events capture by default. #924

Merged
merged 1 commit into from
Sep 20, 2023

Conversation

umaannamalai
Copy link
Contributor

This PR disables machine_learning.inference_events_value.enabled by default.

@umaannamalai umaannamalai requested a review from a team September 20, 2023 21:48
@github-actions
Copy link

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON bandit 1 0 5.21s
✅ PYTHON black 1 0 0 0.75s
✅ PYTHON flake8 1 0 0.45s
✅ PYTHON isort 1 0 0 0.2s
✅ PYTHON pylint 1 0 3.01s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@codecov-commenter
Copy link

Codecov Report

Merging #924 (247cbb4) into develop-scikitlearn (3465cdd) will not change coverage.
The diff coverage is n/a.

@@                 Coverage Diff                  @@
##           develop-scikitlearn     #924   +/-   ##
====================================================
  Coverage                81.75%   81.75%           
====================================================
  Files                      190      190           
  Lines                    19581    19581           
  Branches                  3401     3401           
====================================================
  Hits                     16008    16008           
  Misses                    2590     2590           
  Partials                   983      983           
Files Changed Coverage Δ
newrelic/core/config.py 94.21% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@umaannamalai umaannamalai merged commit 42af773 into develop-scikitlearn Sep 20, 2023
@umaannamalai umaannamalai deleted the disable-inference-events branch September 20, 2023 23:05
@umaannamalai umaannamalai added this to the v9.1.0 milestone Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants