Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix label name warning #915

Merged
merged 2 commits into from
Aug 31, 2023
Merged

Fix label name warning #915

merged 2 commits into from
Aug 31, 2023

Conversation

hmstepanek
Copy link
Contributor

Overview

Previously a warning would show if the user didn't set the label names. This warning should only show if the user does set them and they don't match in length.

@hmstepanek hmstepanek changed the base branch from main to develop-scikitlearn August 31, 2023 18:14
@hmstepanek hmstepanek marked this pull request as ready for review August 31, 2023 18:14
@hmstepanek hmstepanek requested a review from a team August 31, 2023 18:14
@github-actions
Copy link

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON bandit 1 0 4.89s
✅ PYTHON black 1 0 0 0.58s
✅ PYTHON flake8 1 0 0.36s
✅ PYTHON isort 1 0 0 0.19s
✅ PYTHON pylint 1 0 2.88s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (develop-scikitlearn@127ad0c). Click here to learn what that means.
The diff coverage is n/a.

@@                  Coverage Diff                   @@
##             develop-scikitlearn     #915   +/-   ##
======================================================
  Coverage                       ?   81.81%           
======================================================
  Files                          ?      187           
  Lines                          ?    19280           
  Branches                       ?     3310           
======================================================
  Hits                           ?    15773           
  Misses                         ?     2593           
  Partials                       ?      914           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@lrafeei lrafeei merged commit 284e3c4 into develop-scikitlearn Aug 31, 2023
@lrafeei lrafeei deleted the fix-label-name-warning branch August 31, 2023 23:42
@mergify mergify bot removed the tests-failing label Aug 31, 2023
@umaannamalai umaannamalai added this to the v9.1.0 milestone Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants