Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Obtain FirstInteraction directly from performance API #1410

Merged
merged 9 commits into from
Mar 11, 2025

Conversation

metal-messiah
Copy link
Member

@metal-messiah metal-messiah commented Mar 10, 2025

To alleviate the potential performance impact of creating new performance observers to support legacy FirstInteraction timings, a change has been made to query the performance API directly for the presence of first-input data without the use of an observer at logical checkpoints.

Overview

Related Issue(s)

https://new-relic.atlassian.net/browse/NR-365650

Testing

New tests and test fixes for e2e and unit

Copy link

github-actions bot commented Mar 10, 2025

Asset Size Report

Merging this pull request will result in the following asset size changes:

Agent Asset Previous Size New Size Diff
lite loader 30.01 kB / 10.89 kB (gzip) 30.01 kB / 10.89 kB (gzip) 0% / 0.01% (gzip)
lite async-chunk 51.3 kB / 16.77 kB (gzip) 52.03 kB / 16.99 kB (gzip) 1.41% / 1.31% (gzip)
pro loader 52.13 kB / 17.95 kB (gzip) 52.13 kB / 17.95 kB (gzip) 0% / -0.01% (gzip)
pro async-chunk 100.3 kB / 30.63 kB (gzip) 100.58 kB / 30.7 kB (gzip) 0.28% / 0.23% (gzip)
spa loader 59.75 kB / 20.27 kB (gzip) 59.75 kB / 20.27 kB (gzip) 0% / 0% (gzip)
spa async-chunk 115.01 kB / 34.96 kB (gzip) 115.3 kB / 35.05 kB (gzip) 0.25% / 0.25% (gzip)

Copy link

github-actions bot commented Mar 10, 2025

Static Badge

Last ran on March 11, 2025 09:30:15 CDT
Checking merge of (4b4ab95) into main (2b093e8)

Copy link

codecov bot commented Mar 11, 2025

Codecov Report

Attention: Patch coverage is 93.02326% with 3 lines in your changes missing coverage. Please review.

Project coverage is 88.70%. Comparing base (2b093e8) to head (6e41564).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
src/common/util/event-origin.js 90.00% 1 Missing and 1 partial ⚠️
.../features/session_trace/aggregate/trace/storage.js 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1410      +/-   ##
==========================================
+ Coverage   88.66%   88.70%   +0.04%     
==========================================
  Files         169      170       +1     
  Lines        7411     7413       +2     
  Branches     1504     1505       +1     
==========================================
+ Hits         6571     6576       +5     
+ Misses        733      728       -5     
- Partials      107      109       +2     
Flag Coverage Δ
unit-tests 79.99% <82.35%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@metal-messiah metal-messiah marked this pull request as ready for review March 11, 2025 15:10
@metal-messiah metal-messiah changed the title feat: FirstInteraction from performance API fix: Obtain FirstInteraction directly from performance API Mar 11, 2025
ptang-nr
ptang-nr previously approved these changes Mar 11, 2025
@metal-messiah metal-messiah merged commit 22ef4ff into main Mar 11, 2025
17 checks passed
@metal-messiah metal-messiah deleted the NR-365650-get-fi-from-first-input branch March 11, 2025 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants