Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: remove cppcheck-old target/job #6676

Merged
merged 1 commit into from
Mar 7, 2025

Conversation

kmk3
Copy link
Collaborator

@kmk3 kmk3 commented Mar 6, 2025

To avoid CI failures.

From the first run of cppcheck_old on commit 8f69e98 ("bugfix:
firecfg: check full filename in check_profile() (#6674)", 2025-03-04)
[1]:

This is a scheduled Ubuntu 20.04 brownout. Ubuntu 20.04 LTS runner
will be removed on 2025-04-01. For more details, see
actions/runner-images#11101

The target depends on the cppcheck version from Ubuntu 20.04 in order to
work properly and this distribution will become EOL next month (April
2025), so just remove the target.

Added on commit 53f0b39 ("CI: keep old cppcheck job and ignore two
files in new job that take too long to check", 2022-07-26).

[1] https://github.com/netblue30/firejail/actions/runs/13658953453/job/38185280665

To avoid CI failures.

From the first run of `cppcheck_old` on commit 8f69e98 ("bugfix:
firecfg: check full filename in check_profile() (netblue30#6674)", 2025-03-04)
[1]:

> This is a scheduled Ubuntu 20.04 brownout. Ubuntu 20.04 LTS runner
> will be removed on 2025-04-01. For more details, see
> actions/runner-images#11101

The target depends on the cppcheck version from Ubuntu 20.04 in order to
work properly and this distribution will become EOL next month (April
2025), so just remove the target.

Added on commit 53f0b39 ("CI: keep old cppcheck job and ignore two
files in new job that take too long to check", 2022-07-26).

[1] https://github.com/netblue30/firejail/actions/runs/13658953453/job/38185280665
@kmk3 kmk3 merged commit e98395b into netblue30:master Mar 7, 2025
12 checks passed
@kmk3 kmk3 deleted the build-remove-cppcheck-old branch March 7, 2025 03:54
@kmk3 kmk3 added the removal Removal of a feature/option label Mar 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
removal Removal of a feature/option
Projects
Status: Done (on RELNOTES)
Development

Successfully merging this pull request may close these issues.

1 participant