Set zero gc period for test_ondemand_download_large_rel as intended
#3985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LizardWizzard
commented
Apr 7, 2023
| tenant, _ = env.neon_cli.create_tenant( | ||
| conf={ | ||
| # disable background GC | ||
| "gc_period": "10 m", |
There was a problem hiding this comment.
The main change that this now become 0
This comment was marked as outdated.
This comment was marked as outdated.
Test results for c883d85:debug build: 212 tests run: 202 passed, 0 failed, 10 (full report)release build: 212 tests run: 202 passed, 0 failed, 10 (full report) |
LizardWizzard
force-pushed
the
dkr/truly-disable-gc
branch
from
1f15d40 to
c883d85
Compare
|
I think I have a draft pr wrt this test and I think I found this is not enough. #3697. |
|
Also, are the submodule changes intended or by mistake? |
Oh, I havent seen this one, I'll close this one then. I was also thinking about merging configs for different tests because they are quite similar.
Yep, this is not intended, was checking out back and forth and forgot to update submodules |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like it is the source of flakiness in this test.
Reuse some config parts across tests.