Update aggregate documentation for 6.x #239
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsill-neo4j
reviewed
Mar 6, 2025
| Related nodes can also be aggregated within a query by accessing the aggregation fields in the connection. | ||
| In these fields, you can **count**, aggregate the **nodes** or **edges** fields. | ||
|
|
||
| The same selections and types as before are available in relationship aggregations. |
There was a problem hiding this comment.
Suggested change
| The same selections and types as before are available in relationship aggregations. | |
| The same selections and types as in xref:#_aggregation_fields[] are available in relationship aggregations. |
what does "as before" refer to? asking because a link or even repeating the info might make it easier for readers
There was a problem hiding this comment.
TBH, this is not new documentation, just updating examples in this PR, but I presume it refers to the section "
== Aggregation fields"
There was a problem hiding this comment.
(tricked myself with github views)
updated suggestion
|
just 6.x? or also relevant for 7.x? |
|
@rsill-neo4j This should also be in 7.x However, this docs are for an upcoming release. They shouldn't be merged until that release is ready |
Co-authored-by: Richard Sill <[email protected]>
|
This PR includes documentation updates Updated pages: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates documentation on 6.x to match the changes made on neo4j/graphql#5945