Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Discrete Event Visualization in Timeline #7967
base: master
Are you sure you want to change the base?
Discrete Event Visualization in Timeline #7967
Changes from 61 commits
3159de0
680b095
7b22cf3
7af3996
944634d
55bed6a
2776cc8
5b006b6
8b5e2f4
3b236cc
0db301d
e9f120a
d046ad1
052129b
6f26add
aaec052
96d8870
3829295
3d3f093
64bd625
781d834
d97f7c3
cda7cc9
d048af1
62b4975
20247bb
20426fe
6bda108
aaa2e43
2ba6bc9
3af9083
36d3197
72ff0bc
f4ec532
49a106b
cba7c7f
2ae1fe1
b865d8c
27af030
099153b
546714b
51d9654
68fc317
531ef3e
638b03c
601fc33
8c72e4a
65b1f02
3c24205
5312458
bb4fea7
5b28086
9522040
6cafa7a
cfa2129
e6cb940
f163034
0933d27
15b674f
0e940b2
32a0e15
9e68514
1ced12d
3ad64f0
aa5fa46
74a5d7e
157bde8
8be969f
14a5c47
88b4331
b171f82
af6f327
bbae9c6
55d15ca
8545dde
2e35212
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 74 in example/eventGenerator/EventLimitProvider.js
example/eventGenerator/EventLimitProvider.js#L74
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need to decide if we want this to be the default plugin in core. Traditionally, we don't add new plugins for e2e tests and run the
addInitScript
to add the plugin at runtime.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, will defer this to @charlesh88 or @akhenry