interp: implement %b for printf builtin #955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reubeno
changed the title
mvdan
reviewed
Dec 7, 2022
Update printf implementation to do the same as 'echo -e' for the %b format specifier handled by bash: expand backslash escape sequences in the provided argument but not % format specifiers.
reubeno
force-pushed
the
printf-percent-b
branch
from
2d1e32e to
3e82b7b
Compare
mvdan
approved these changes
Dec 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
printfimplementation to do the same asecho -efor the%bformat specifier: expand backslash escape sequences in the provided argument but not%format specifiers.Extracts inner logic from
FormatintoformatIntoBufferto avoid issues with non-reentrancy ofFormat(due to use of a special cached buffer inConfig.Request for feedback
This was the simplest change that I could see, but I wasn't thrilled about having
formatIntoBufferrecursively call itself for the%bcase; this shouldn't generally be problematic, since the recursive call won't process%format specifiers and shouldn't further recur.