Add support for external links in link component #7784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olmoh
changed the title
tobias-jarvelov
requested changes
Mar 10, 2025
...llvad-vpn/src/renderer/lib/components/navigation-header/components/NavigationHeaderTitle.tsx
Outdated
Show resolved
Hide resolved
desktop/packages/mullvad-vpn/src/renderer/lib/components/typography/Text.tsx
Outdated
Show resolved
Hide resolved
| color={color} | ||
| $hoverColor={getHoverColor(color)} | ||
| {...props}> | ||
| <StyledText forwardedAs={as ?? 'a'} color={color} $hoverColor={getHoverColor(color)} {...props}> |
There was a problem hiding this comment.
question: Couldn't we set the default value for the as prop in the destructuring of the Link's props?
export const Link = <T extends WebTarget = 'a'>({
as = 'a',
children,
...
<StyledText forwardedAs={as} ...I seem to recall this being a pattern we've used previously.
There was a problem hiding this comment.
This is indeed more in line with how we do in it other places so makes sense to do it here as well. Had to cast it here though to make the types happy.
desktop/packages/mullvad-vpn/src/renderer/lib/components/typography/Text.tsx
Show resolved
Hide resolved
desktop/packages/mullvad-vpn/src/renderer/lib/components/typography/Link.tsx
Outdated
Show resolved
Hide resolved
desktop/packages/mullvad-vpn/src/renderer/lib/components/typography/FootnoteMini.tsx
Outdated
Show resolved
Hide resolved
olmoh
force-pushed
the
add-support-for-external-links-in-link-component-des-1826
branch
from
e262683 to
33a94e0
Compare
olmoh
force-pushed
the
add-support-for-external-links-in-link-component-des-1826
branch
from
33a94e0 to
218471d
Compare
olmoh
force-pushed
the
add-support-for-external-links-in-link-component-des-1826
branch
from
218471d to
15a72ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves app specific logic from
Linkcomponent to two separate components,ExternalLinkandInternalLink.This change is